-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Scoped Values (JEP 429) #16678
Support for Scoped Values (JEP 429) #16678
Conversation
40d4d00
to
26112a8
Compare
This PR contains changes related to the code, which fixed the failures reported in ibmruntimes/openj9-openjdk-jdk#531 (comment). Started a personal build to verify this PR (JDK19 + JDK20, sanity.functional + sanity.openjdk): https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/15472/. |
In the above personal build, |
8f8ef18
to
a96ff1e
Compare
@JasonFengJ9 Addressed all your feedback. Removed |
a96ff1e
to
abad734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@keithc-ca please review/merge. |
Given the short life-expectancy of Java 19, perhaps it makes sense to just use the new name |
abad734
to
14d977a
Compare
@keithc-ca Addressed all your feedback. |
14d977a
to
5388f59
Compare
In JDK20, extentLocalCache is renamed to scopedValueCache. JDK19 and JDK20 changes are completely segregated to avoid cross-contamination if the implementation differs a lot across JDK versions. TODO: Thread.findScopedValueBindings needs to be implemented. This is tracked in eclipse-openj9#16677. Fixes: eclipse-openj9#16657 Signed-off-by: Babneet Singh <[email protected]>
5388f59
to
297738f
Compare
Jenkins test sanity alinux64 jdk19,jdk20 |
In JDK20,
extentLocalCache
is renamed toscopedValueCache
.JDK19 and JDK20 changes are completely segregated to avoid
cross-contamination if the implementation differs a lot across
JDK versions.
TODO:
Thread.findScopedValueBindings
needs to be implemented.This is tracked in #16677.
Related: #16439
Fixes: #16657
Signed-off-by: Babneet Singh [email protected]